[PATCH] D123610: [Testing] Drop clangTesting from clang's public library interface

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

The change makes sense to me.



================
Comment at: clang/lib/Testing/CMakeLists.txt:6
+# Not add_clang_library: this is not part of clang's public library interface.
+# Unit tests should depend on this with target_link_libraries, not clang_TLL.
+add_llvm_library(clangTesting
----------------
OOO, what is `clang_TLL`?


================
Comment at: clang/lib/Testing/CMakeLists.txt:7
+# Unit tests should depend on this with target_link_libraries, not clang_TLL.
+add_llvm_library(clangTesting
   CommandLineArgs.cpp
----------------
no related to this patch, I think `clangTestingSupport` is a better name (also align with the LLVM one). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123610/new/

https://reviews.llvm.org/D123610