[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

Tue Apr 12 11:17:18 PDT 2022

MaskRay added a comment.

In D123544#3446285 <https://reviews.llvm.org/D123544#3446285>, @lebedev.ri wrote:

> Does this not lead to non-deterministic/non-reproducible builds?
> I do not understand why this feature must be inflicted onto everyone.

It seems that the feature fixes the randomization seed in the option `-frandomize-layout-seed=`, so it is deterministic, but it currently has a possible Windows vs non-Windows host difference, probably related to MSVC's `std::mt19937`.
My concern is related to the lack of `-frandomize-layout-seed-file=` testing in the base patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123544/new/

https://reviews.llvm.org/D123544