[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 11 13:10:05 PDT 2022


rsmith added a comment.

The patch description doesn't match the patch: we have `__remove_cv` in the description but `__remove_cv_qualifiers` in the patch. It seems unfortunate to me to use a long-term bad name for our trait to  work around a (likely) short-term problem with a specific version of libstdc++. Perhaps we could demote the `__remove_cv` keyword to a plain identifier if it's not followed by a `(` instead (we've done similar things for other trait keywords that have conflicted with libstdc++); would that be enough to resolve the incompatibility?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116203/new/

https://reviews.llvm.org/D116203



More information about the cfe-commits mailing list