[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

[Zixu Wang via Phabricator via cfe-commits]

zixuw added inline comments.


================
Comment at: clang/test/ExtractAPI/enum.c:684
+        },
+        "uri": "file:///Users/dgrumberg/VersionControlledDocuments/oss/llvm-project/build/tools/clang/test/ExtractAPI/Output/enum.c.tmp/input.h"
+      },
----------------
nit: normalize


================
Comment at: clang/test/ExtractAPI/enum.c:693
+        ],
+        "title": "(anonymous)"
+      },
----------------
So the `Name` of the record is literally `(anonymous)`? I think this might create problems (well I guess we always had this problem) that multiple anonymous records of the same kind getting the same `Name`, and `RecordMap` is indexed with it...
We should switch the key of `RecordMap`s to `USR` instead probably.


================
Comment at: clang/test/ExtractAPI/enum.c:720
+        },
+        "uri": "file:///Users/dgrumberg/VersionControlledDocuments/oss/llvm-project/build/tools/clang/test/ExtractAPI/Output/enum.c.tmp/input.h"
+      },
----------------
nit: normalize


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123533/new/

https://reviews.llvm.org/D123533