[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 11 07:39:47 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thank you for the fix! Can you add a release note for it as well?
LGTM aside from a minor nit with some comment wording and a testing suggestion.
================
Comment at: clang/test/SemaCXX/warn-once-on-unknown-attr.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11
+void foo() {
----------------
Can you also add this RUN line?
`// RUN: %clang_cc1 -fsyntax-only -verify -std=c2x -x c %s`
Then we're verifying that we didn't do anything different for C.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123447/new/
https://reviews.llvm.org/D123447
More information about the cfe-commits
mailing list