[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 11 02:38:29 PDT 2022
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Oopsy :/ Thanks for the fix!
Regarding the test, if you came looking for this piece due to a particular issue, it might be nice to have that included in the test suite (assuming it can be minimized).
If not, I think it would still be valuable to include a simple unittest that just tests `operator<` by creating `HighlightingTokens` to make sure we don't make similar mistakes in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123478/new/
https://reviews.llvm.org/D123478
More information about the cfe-commits
mailing list