[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 10 19:03:48 PDT 2022


nridge added a comment.

Not sure how to write a test for this, short of writing unit tests for the operator< itself. The consequence of this bug is that the sort/unique pass on the highlighting tokens is buggy, but as of https://github.com/clangd/clangd/issues/1057 `resolveConflict()` fixes up that kind of bugginess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123478/new/

https://reviews.llvm.org/D123478



More information about the cfe-commits mailing list