[PATCH] D121556: [randstruct] Add randomize structure layout support

Bill Wendling via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 8 17:44:36 PDT 2022


void added a comment.

In D121556#3440308 <https://reviews.llvm.org/D121556#3440308>, @thakis wrote:

> It's more important to remove it from the cmakelists file than to delete the source file ;)
>
> Please revert the whole thing instead of just removing the test coverage though. You can reland when the test is figured out, and that makes sure this doesn't stay in without coverage.

I'd rather not re-land the whole thing. The test isn't that important, and quite frankly it might not be possible to test it with the unittest. Too many architectures seem to have a different randomization algorithm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121556/new/

https://reviews.llvm.org/D121556



More information about the cfe-commits mailing list