[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 8 11:44:06 PDT 2022
LegalizeAdulthood marked 4 inline comments as done.
LegalizeAdulthood added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281
+inline StringRef getTokenName(const Token &Tok) {
+ return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifier()
----------------
njames93 wrote:
> inline is pretty redundant here. Did you mean to make this static?
ReSharper flagged this as redundant as well, but I'm not sure I understand why inline is redundant here.
Static is definitely redundant because this is all inside an anonymous namespace block.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123349/new/
https://reviews.llvm.org/D123349
More information about the cfe-commits
mailing list