[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.
Mitch Phillips via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 8 11:09:05 PDT 2022
hctim added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475
def err_stack_tagging_requires_hardware_feature : Error<
- "'-fsanitize=memtag' requires hardware support (+memtag)">;
+ "'-fsanitize=memtag-stack' requires hardware support (+memtag). For Armv8, "
+ "try compiling with -march=armv8a+memtag.">;
> MaskRay wrote:
> > hctim wrote:
> > > eugenis wrote:
> > > > Split out renaming of memtag to memtag-stack first? This will remove a lot of diff from this patch.
> > > splitting into elf -> lld -> clang as per Ray's suggestion, should reduce the diff enough.
> > The convention is to omit period for the last sentence.
> Mention armv9a, too?
> Something like "Try compiling with -march=armv9a, or -march=armv8a+memtag"
mentioned it similar to armv8, as mentioned we're not 100% clear whether MTE is mandatory on armv9.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits