[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

Saiyedul Islam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 8 09:45:09 PDT 2022


saiislam accepted this revision.
saiislam added a comment.

In D123387#3439069 <https://reviews.llvm.org/D123387#3439069>, @yaxunl wrote:

> Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

I think lit tests were passing because all occurrences of -outputs were replaced with -output. It crashed internally in other components where this syntax wasn't changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123387/new/

https://reviews.llvm.org/D123387



More information about the cfe-commits mailing list