[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 22:18:28 PDT 2022

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.

Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475
 def err_stack_tagging_requires_hardware_feature : Error<
-  "'-fsanitize=memtag' requires hardware support (+memtag)">;
+  "'-fsanitize=memtag-stack' requires hardware support (+memtag). For Armv8, "
+  "try compiling with -march=armv8a+memtag.">;
hctim wrote:
> eugenis wrote:
> > Split out renaming of memtag to memtag-stack first? This will remove a lot of diff from this patch.
> splitting into elf -> lld -> clang as per Ray's suggestion, should reduce the diff enough.
The convention is to omit period for the last sentence.

Comment at: clang/include/clang/Driver/Options.td:1619
+                                        Group<f_clang_Group>,
+                                        HelpText<"Set default MTE mode to 'async' (default) or 'sync'.">;
 def fsanitize_hwaddress_experimental_aliasing
eugenis wrote:
> Let's make "sync" the default mode.
Omit period for the last sentence

Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1013
+      TC.getDriver().Diag(diag::err_drv_unsupported_opt_for_target)
+          << ("-fsanitize=memtag*") << TC.getTriple().str();
+    }

Comment at: clang/test/Lexer/has_feature_memtag.cpp:5
+// RUN:     | FileCheck --check-prefixes=CHECK-MEMTAG-STACK,CHECK-MEMTAG-HEAP %s
+// RUN: %clang_cc1 -E  %s -o - | FileCheck --check-prefix=CHECK-NO-MEMTAG %s

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list