[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 11:40:01 PDT 2022


zixuw added inline comments.


================
Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495
 
+    if (const auto *Method = dyn_cast<ObjCMethodRecord>(Member.get()))
+      serializeObject(*MemberRecord, "functionSignature",
----------------
I'd prefer not to use `dyn_cast` as `MemberTy` here is a concrete type. So maybe a type trait `has_function_signature` and a `if constexpr`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123304/new/

https://reviews.llvm.org/D123304



More information about the cfe-commits mailing list