[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

Quinn Pham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 10:37:27 PDT 2022


quinnp added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627
+    Value *Y =
+        Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3));
     return Builder.CreateOr(X, Y);
----------------
nemanjai wrote:
> Nit: I understand that we only have one use of `E->getArg(1)`, but might as well initialize `Op1` as above just for consistency.
I've fixed all the instances of this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121637/new/

https://reviews.llvm.org/D121637



More information about the cfe-commits mailing list