[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

Thu Apr 7 04:56:42 PDT 2022

cor3ntin added a comment.

In D123298#3435770 <https://reviews.llvm.org/D123298#3435770>, @aaron.ballman wrote:

> Changes LGTM, I also don't think we should hit these limits. Perhaps we should add some assertions to the ctor and the setter functions just to be sure though?

If we are going to do anything, it ought to be a diagnostic? 
I can't imagine a scenario in which someone would hit these limits and have assertions enabled. But i agree with you that the limit themselves should not be hit. 
On the other hand, why not use 16 for both?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123298/new/

https://reviews.llvm.org/D123298