[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

Kai Luo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 6 21:03:45 PDT 2022


lkail added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.h:440
     if (Triple.isOSAIX() || Triple.isOSLinux())
       DataLayout += "-S128-v256:256:256-v512:512:512";
     resetDataLayout(DataLayout);
----------------
adalava wrote:
> I don't understand what DataLayout does mean, but I'm wondering why FreeBSD doesn't append this as well.  Is it expected to be AIX() and Linux only?
As maskray has pointed out, usually using `isOSBinFormatELF` rather than `isOSLinux` can cover freebsd as well. This snippet of code might be beyond this patch, we might post another one to address this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122377/new/

https://reviews.llvm.org/D122377



More information about the cfe-commits mailing list