[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 6 11:54:00 PDT 2022
dexonsmith added a comment.
(Seeing the other replies now!)
In D123197#3433846 <https://reviews.llvm.org/D123197#3433846>, @sammccall wrote:
> I think it's worth making the test a bit uglier to achieve that, and by contrast adding inheritance to FileManager would make it harder to understand.
> Some ideas, do any seem acceptable?
> - have FileEntry `friend class FileEntryTest` or so
This idea sounds good to me.
I also like the idea I just posted (change to an initializing constructor), but it's more work and I'm fine with the `friend class FileEntryTest` as a way forward if you'd prefer it.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits