[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer
Victoria Mitchell via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 6 08:12:28 PDT 2022
QuietMisdreavus accepted this revision.
QuietMisdreavus added a comment.
This revision is now accepted and ready to land.
I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now.
Comment at: clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h:125
/// containing common symbol information of \p Record.
- Optional<Object> serializeAPIRecord(const APIRecord &Record) const;
+ Optional<Object> serializeAPIRecord(const APIRecord &Record);
Now that the path components are being manipulated outside of `serializeAPIRecord`, can this function become `const` again?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits