[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with a couple of small changes noted below.



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:167
 
+  /// Check whether we should emit a module summary.
+  /// The module summary should be emitted by default for Regular LTO
----------------
Add "for regular LTO" (this check is not appropriate for ThinLTO). I'd prefer to make the name "shouldEmitRegularLTOSummary" to be explicit about this too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123026/new/

https://reviews.llvm.org/D123026