[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method
Teresa Johnson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 6 07:55:45 PDT 2022
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm with a couple of small changes noted below.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:167
+ /// Check whether we should emit a module summary.
+ /// The module summary should be emitted by default for Regular LTO
Add "for regular LTO" (this check is not appropriate for ThinLTO). I'd prefer to make the name "shouldEmitRegularLTOSummary" to be explicit about this too.
CHANGES SINCE LAST ACTION
More information about the cfe-commits