[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:483
+
+  llvm::ModulePassManager MPM;
+  llvm::ModuleAnalysisManager MAM;
----------------
rovka wrote:
> Nit: I think you can move these closer to their first use.
Thanks, I thought that I _did_ move it :)


================
Comment at: flang/test/CMakeLists.txt:58
   bbc
+  llvm-dis
   llvm-objdump
----------------
rovka wrote:
> Were you going to add a test that uses this?
Sorry, forgot to add in the original revision. Should be there now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123211/new/

https://reviews.llvm.org/D123211