[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

[Diana Picus via Phabricator via cfe-commits]

rovka added a comment.

Why not use the BackendAction for this? There seems to be a lot of shared code, up until the point where you create and use the pass manager (and in the future, when the backend switches to the new pass manager, there will be even more shared code).



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:483
+
+  llvm::ModulePassManager MPM;
+  llvm::ModuleAnalysisManager MAM;
----------------
Nit: I think you can move these closer to their first use.


================
Comment at: flang/test/CMakeLists.txt:58
   bbc
+  llvm-dis
   llvm-objdump
----------------
Were you going to add a test that uses this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123211/new/

https://reviews.llvm.org/D123211