[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 5 17:07:18 PDT 2022
dexonsmith added inline comments.
================
Comment at: clang/include/clang/Lex/HeaderSearch.h:758
+ bool IsSystemHeaderDir,
+ StringRef FileName = "");
----------------
benlangmuir wrote:
> This parameter could use a comment, even if it just points you to read the FIXME in the implementation.
Good point; maybe it could have a better name/type, too, something like:
```
lang=c++
Optional<StringRef> OverrideModuleMapFilename = None
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123104/new/
https://reviews.llvm.org/D123104
More information about the cfe-commits
mailing list