[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 13:54:10 PDT 2022

aaron.ballman added a comment.

In D123074#3430705 <https://reviews.llvm.org/D123074#3430705>, @AaronSiddharthaMondal wrote:

> @aaron.ballman There may have been something wrong with the commit. On GitHub it does not link to my user account. Would it be possible to change that?
> The github name is aaronmondal.

Sorry for the trouble -- the option to land with attribution takes `name <email at address>` form, not a GitHub username.

I can reland with different attribution, but that churns the git history and makes git blame harder for code archeology, so it's nice to avoid if possible. I think adding your secondary email address to your GitHub account should also address the issue (https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account). But if it doesn't and you'd still like the attribution changed, I can revert and recommit (probably tomorrow at this point, I'm just about done for the day today).

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list