[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 13:20:44 PDT 2022


zixuw added inline comments.


================
Comment at: clang/test/ExtractAPI/known_files_only.c:20
+// Let's make sure we aren't pulling in symbols from complex.h
+#include <complex.h>
+double complex build_complex(double real, double imaginary);
----------------
I would just include another header split from this test file but not passed into the command line to avoid pulling in extra dependencies. Makes the test self-contained and more consistent, also simpler.


================
Comment at: clang/test/ExtractAPI/known_files_only.c:166
+        "line": 5,
+        "uri": "file:///Users/dgrumberg/VersionControlledDocuments/oss/llvm-project/build/tools/clang/test/ExtractAPI/Output/known_files_only.c.tmp/input1.h"
+      },
----------------
uri not normalized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123148/new/

https://reviews.llvm.org/D123148



More information about the cfe-commits mailing list