[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 12:03:54 PDT 2022

aaron.ballman added a comment.

In D122529#3422688 <https://reviews.llvm.org/D122529#3422688>, @njames93 wrote:

> In D122529#3422158 <https://reviews.llvm.org/D122529#3422158>, @aaron.ballman wrote:
>> This looks.... good?.... to me. :-)
>> Despite this complicating things by a fair amount, I don't have a better suggestion to offer. LGTM
> This was the "nicest" cheapest way I could think to implement this, It's also why I thought it best to resubmit this for review.
> Annoyingly this is now suboptimal for 64bit code, but I'm not sure it's worth writing 2 implementations for 64 and 32 bit.

Given that it has to do with crash analysis (which had better not be performance sensitive!!), I think I agree it's not worth writing two implementations for this.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list