[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

Tom Honermann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 11:57:50 PDT 2022


tahonermann abandoned this revision.
tahonermann added a comment.

Abandoning this review; the changes made here have been squashed into D122958 <https://reviews.llvm.org/D122958>.

With regard to prior comments, it seems we have divergent experience regarding the utility of separating commits as I initially did (I also have a ton of code archeology experience). However, I acknowledge that I am the newcomer to this community and I am content to follow existing community norms (and will lobby for change through appropriate channels (e.g., not within a code review!) if I believe such change would be beneficial).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122954/new/

https://reviews.llvm.org/D122954



More information about the cfe-commits mailing list