[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 5 08:32:51 PDT 2022


tejohnson added a comment.

I'd prefer to keep the setting of the module flags inline here. The main reason is that the EnableSplitLTOUnit module flag is also set inline for the ThinLTO case just above, and it is easier to see what is going on if they are near each other. Suggest making the new emitLTOSummary just about checking the conditions for emitting the summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123026/new/

https://reviews.llvm.org/D123026



More information about the cfe-commits mailing list