[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

Tue Apr 5 05:15:41 PDT 2022

awarzynski accepted this revision.
awarzynski added a subscriber: jansvoboda11.
awarzynski added a comment.
This revision is now accepted and ready to land.

Thanks for doing this, Emil!

This is a much appreciated clean-up. On quite a few occasions I got confused with the nested `let` statements. With this change, everyone should find it easier to identify precisely what flags are effectively set for a particular option.

> There are probably a developer or two on the clang side that ought to have a say on this.

I agree that we should try to reach as many reviewers as possible. @jansvoboda11 was kind enough to review some changes for me in the past. I'll also ping Discourse. But I think that you should go ahead with this even there no more reviewers :) It's an NFC and a clear improvement compared to what we have now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123070/new/

https://reviews.llvm.org/D123070