[PATCH] D123037: [clang][dataflow] Support integral casts

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev accepted this revision.
sgatev added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:206
+      // boolean.
+      auto &ExprLoc = Env.createStorageLocation(*S);
+      Env.setStorageLocation(*S, ExprLoc);
----------------
Nit: Just `Loc`? I believe that's what we use in other places in this file if it's a location for `S`.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1904
-                const auto *FooVal =
-                    cast<IntegerValue>(Env.getValue(*FooDecl, SkipPast::None));
-                const auto *BarVal =
----------------
Why not assert the type of the value in this test and in `IntegralCast` below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123037/new/

https://reviews.llvm.org/D123037