[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

Fabio Rossini Sluzala via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 4 15:48:44 PDT 2022

FabioRS marked 2 inline comments as done.
FabioRS added a comment.

In D122698#3426237 <https://reviews.llvm.org/D122698#3426237>, @sammccall wrote:

> Thanks, this looks great! Just a couple of nits left.
> Appreciate you fixing the out-of-line `ns::f()` case too. It's easier to understand the fixed logic than the broken logic.
> I guess you don't have commit access yet, I can land this for you if you like. Let me know your preferred name/email for attribution.

Thanks! I'm glad to help.

I don't have commit access. You can land it for me please, thanks!
Name: Fabio Rossini Sluzala
e-mail: fabio3rs at gmail.com



actor(@FabioRS) application(Differential) author(@FabioRS) herald(H243) herald(H311) herald(H365) herald(H378) herald(H391) herald(H502) herald(H576) herald(H744) herald(H864) mention(@sammccall) monogram(D122698) object-type(DREV) phid(PHID-DREV-cfxk4igkfserwacndt5w) reviewer(@sammccall) revision-status(accepted) subscriber(@arphaman) subscriber(@cfe-commits) subscriber(@ilya-biryukov) subscriber(@kadircet) subscriber(@MaskRay) subscriber(@nridge) subscriber(@usaxena95) tag(#all) tag(#clang-tools-extra) via(web)

More information about the cfe-commits mailing list