[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:513
+  const RecordDecl *RD = BaseTy->getDecl();
+  if (RD->getIdentifier() == nullptr || RD->getName() != "Message")
+    return false;
----------------
Not sure how often is this invoked but we could reduce the number of string comparisons by caching the identifier ptr and do a pointer comparison.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123032/new/

https://reviews.llvm.org/D123032

STAMPS
actor(@xazax.hun) application(Differential) author(@ymandel) herald(H256) herald(H423) herald(H570) herald(H576) herald(H678) herald(H832) herald(H853) herald(H857) herald(H864) monogram(D123032) object-type(DREV) phid(PHID-DREV-mwcfw3jkwlzkhod5l25r) reviewer(@sgatev) reviewer(@xazax.hun) revision-repository(rG) revision-status(needs-review) subscriber(@cfe-commits) subscriber(@gribozavr2) subscriber(@kinu) subscriber(@rnkovacs) subscriber(@steakhal) subscriber(@tschuett) tag(#all) tag(#clang) via(web)