[PATCH] D122008: [flang][driver] Add support for generating executables

Valentin Clement via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 4 12:11:46 PDT 2022

clementval added a comment.

In D122008#3426847 <https://reviews.llvm.org/D122008#3426847>, @awarzynski wrote:

> We discussed this patch in our community call today and some people expressed their reservations about merging this just now. As I mentioned, I would like to have this merged to unblock the CMake PR <https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6323>. As promised, here are the options that we've considered:
> 1. merge this patch "today",
> 2. merge this patch "today", but add a flag so that by default `flang-new file.f90` wouldn't generate an executable (we would remove this flag at a later time),
> 3. wait until the upstreaming of fir-dev is complete (based on today's update, I think that that would be in June/July the earliest).
> Could you tell me what your preference is?
> Please keep in mind that even once CMake support is available, it's going to land in the "latest" version of CMake. Folks will have to download the latest binaries from https://github.com/Kitware/CMake/releases in order to benefit from this.  With time, CMake shipped with various OSes will catch-up and become "modern" enough. But there's going to be a delay and hence it makes sense to get the CMake support sooner rather than later.
> Please comment if I missed or misinterpreted anything. Also, I will add more reviewers - basically everyone who discussed this in the call today. Please add anyone that I've missed!
> Thanks for taking a look!

I'll personally in favor of number 3.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list