[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 4 07:49:40 PDT 2022
kbobyrev added a comment.
In D123031#3426303 <https://reviews.llvm.org/D123031#3426303>, @kadircet wrote:
> note that you seem to be using `auto PublicHeader = CanonIncludes.mapHeader(Entry->getName());` (i.e. `getName`) in D120306 <https://reviews.llvm.org/D120306> and not `tryGetRealPathName`. it might be nice to have a test case here, at least one that only fails/runs on windows
Right! I think I also need to do that in `SymbolCollector.cpp`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits