[PATCH] D122935: [AST] Dont invalidate a ref-type var decl if it has no initializer.

Mon Apr 4 07:25:51 PDT 2022

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

I'd be surprised if this *doesn't* break some fragile assumption somewhere, but it's a good change.

For the record, the setInvalid was added in e6565625f456123ad6eb33c84c8100d8f9411192. The other setInvalids from that patch:

- are for variables with incomplete/abstract types ==> these are correct I think
- are for init-sequence failures ==> these were removed by you in 9657385960350150b77ed652175b4c3801abd7fa <https://reviews.llvm.org/rG9657385960350150b77ed652175b4c3801abd7fa> and a forked case in 89d9912cbf45068770ac8c1e2ef97b74c3b662ab <https://reviews.llvm.org/rG89d9912cbf45068770ac8c1e2ef97b74c3b662ab>

So this feels like tying up a loose end consistent with prior work 👍

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122935/new/

https://reviews.llvm.org/D122935