[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

Mon Apr 4 06:50:03 PDT 2022

thakis added a comment.

In D122820#3426132 <https://reviews.llvm.org/D122820#3426132>, @erichkeane wrote:

> In D122820#3423712 <https://reviews.llvm.org/D122820#3423712>, @thakis wrote:
>
>> Looks like this breaks tests on macOS: http://45.33.8.238/macm1/31733/step_7.txt
>>
>> Please take a look, and revert for now if it takes a while to fix.
>
> That is sad, it seems that llvm-cxxfilt isn't working right on some of the machines :/

Oh hm, if it's due to the wrong llvm-cxxfilt being called, maybe we just need to update clang/test/lit.cfg.py to add llvm-cxxfilt to `tools`  to make sure it uses the just-built one instead of the one on PATH (? not sure).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122820/new/

https://reviews.llvm.org/D122820