[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

Mon Apr 4 06:44:58 PDT 2022

bjope added a comment.

In D121233#3426155 <https://reviews.llvm.org/D121233#3426155>, @sammccall wrote:

> In D121233#3425793 <https://reviews.llvm.org/D121233#3425793>, @bjope wrote:
>
>> Have had problems with failing stage 2 builds since this patch:
>
> Should be fixed in 72ae6cc3a689869dcc15cfa8d0abcdd35a35a484 <https://reviews.llvm.org/rG72ae6cc3a689869dcc15cfa8d0abcdd35a35a484>, please let me know if not.

Yes, you are right. Fantastic finding without me even providing the cmake command.
But it was true that for the failing stage we had disabled tests using `-DLLVM_INCLUDE_TESTS=OFF` which result in CLANG_INCLUDE_TESTS being OFF as well. So your fix to respect the CLANG_INCLUDE_TESTS setting does indeed solve the problem. Thanks alot for the help!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233