[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 23:13:35 PDT 2022


MaskRay added a comment.

In D122789#3424213 <https://reviews.llvm.org/D122789#3424213>, @pengfei wrote:

> In D122789#3423846 <https://reviews.llvm.org/D122789#3423846>, @MaskRay wrote:
>
>> Is this a problem with D105462 <https://reviews.llvm.org/D105462>? Should -msse4.2 imply -mcrc32?
>
> -msse4.2 implies -mcrc32: https://godbolt.org/z/xaPccrKx3

That is my understanding of clang/lib/Basic/Targets/X86.cpp:159 , but the error suggested that D105462 <https://reviews.llvm.org/D105462> might change something in an interesting way.
I am on a trip so do not spend time investigating the root cause.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122789/new/

https://reviews.llvm.org/D122789



More information about the cfe-commits mailing list