[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 09:26:18 PDT 2022


njames93 added a comment.

In D122529#3422158 <https://reviews.llvm.org/D122529#3422158>, @aaron.ballman wrote:

> This looks.... good?.... to me. :-)
>
> Despite this complicating things by a fair amount, I don't have a better suggestion to offer. LGTM

This was the "nicest" cheapest way I could think to implement this, It's also why I thought it best to resubmit this for review.
Annoyingly this is now suboptimal for 64bit code, but I'm not sure it's worth writing 2 implementations for 64 and 32 bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122529/new/

https://reviews.llvm.org/D122529



More information about the cfe-commits mailing list