[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

Wang Yihan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 08:14:31 PDT 2022


yihanaa added a comment.

In D122822#3422463 <https://reviews.llvm.org/D122822#3422463>, @erichkeane wrote:

> In D122822#3421089 <https://reviews.llvm.org/D122822#3421089>, @yihanaa wrote:
>
>> I also agree that this is a useful debugging builtin, and no program logic should be forced to depend on the output of this builtin. It's just used to print out some useful debugging information
>
> FWIW, @rsmith is the clang-codeowner, so he's the one to convince (and @rjmccall is also a very senior reviewer).  So I wouldn't be able to approve this patch without their consent/agreement.

Thank you for your information, @erichkeane I really hope we can find a solution and reach a consensus😊


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122822/new/

https://reviews.llvm.org/D122822



More information about the cfe-commits mailing list