[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 06:12:05 PDT 2022


kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:115
                          bool IsFirstPreamble) {
-  static llvm::once_flag OnceFlag;
-  llvm::call_once(OnceFlag, [&] {
+  auto RecordWithLabel = [&Stats](llvm::StringRef Label) {
     PreambleBuildFilesystemLatency.record(Stats.FileSystemTime, "first_build");
----------------
adamcz wrote:
> You're not using Label anywhere. Replace first_build below with Label.
oops, did that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122894/new/

https://reviews.llvm.org/D122894



More information about the cfe-commits mailing list