[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

[Iain Sandoe via Phabricator via cfe-commits]

iains added inline comments.


================
Comment at: clang/test/Modules/cxx20-hu-04.cpp:22
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface importer-01.cpp \
+// RUN:  -fmodule-file=hu-02.pcm -o B.pcm -DTDIR=%t -verify
+
----------------
hvdijk wrote:
> On Windows, when the path starts with `C:\Users\...`, I am seeing
> ```
> error: 'warning' diagnostics seen but not expected: 
> 
>   Line 1: \U used with no following hex digits; treating as '\' followed by identifier
> 
> 1 error generated.
> ```
> Looking at this test, `TDIR` is only used as a FileCheck variable, can it just be removed from this line?
Sorry about that,  Yes, I think that change should be fine - I will take care of it,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121097/new/

https://reviews.llvm.org/D121097