[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

[Vince Bridgers via Phabricator via cfe-commits]

vabridgers added a comment.

@steakhal, good question. Digging into the change archaeology, I see this change was made by Anna Zaks in Jan 2016 - see commit header below.

There's no reference to a review with comments, and I don't know how to find those if they exist, perhaps @NoQ could help with that?

In any case, judging by the changes I had to make to the test cases, there were no regressions in the current test set, and at least our build tests ran ok - seems like this is no longer necessary. But I understand the need to approach this carefully.

Thanks

  commit c9f16fe48c40e7683d0029b65090d0007414d7af
  Author: Anna Zaks <ganna at apple.com>
  Date:   Wed Jan 6 00:32:49 2016 +0000
  
      [analyzer] Don't report null dereferences on address_space annotated memory
      
      llvm-svn: 256885


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122841/new/

https://reviews.llvm.org/D122841