[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 12:50:18 PDT 2022


erichkeane updated this revision to Diff 419548.
erichkeane added a comment.

Handle the unnamed bitfield case.

I'm still not sure how to reproduce the 'unreachable' example I added that @rjmccall suggested was possible, nor how we can deal with that, so waiting on his feedback for how he thinks we should handle that case.

Presumably I could replace it with a 'don't know how to handle that yet' fatal error like we do in the MS Mangler?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122820/new/

https://reviews.llvm.org/D122820

Files:
  clang/lib/AST/ItaniumMangle.cpp
  clang/test/CodeGenCXX/mangle-nttp-anon-union.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122820.419548.patch
Type: text/x-patch
Size: 6374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220331/3d2672cc/attachment-0001.bin>


More information about the cfe-commits mailing list