[PATCH] D122104: [X86][regcall] Support passing / returning structures

Thu Mar 31 09:05:41 PDT 2022

aaron.ballman added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:3992
     --FreeIntRegs;
+  else if (NeededSSE && MaxVectorWidth > 0)
+    FI.setMaxVectorWidth(MaxVectorWidth);
----------------
erichkeane wrote:
> erichkeane wrote:
> > This line here accesses NeededSSE while uninitialized.  Do you  need to initalize it to something on 3963?
> Fixed: https://github.com/llvm/llvm-project/commit/2267549296dabfed31ce194bb124f7bdb91f74c5
> 
> Please confirm the fix.
I've fixed this in 2267549296dabfed31ce194bb124f7bdb91f74c5 as it broke many tests on Windows (but I don't think one of the community build bots noticed this, which suggests we may want to have a Debug Windows builder).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122104/new/

https://reviews.llvm.org/D122104