[PATCH] D120254: [OpenCL] Align subgroup builtin guards

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 08:43:34 PDT 2022


svenvh added a comment.

I've submitted the fix in `4dfec37037f5`.

As for testing, unfortunately I couldn't just extend the `SemaOpenCL/fdeclare-opencl-builtins.cl` test: the OpenCL 1.2 RUN lines explicitly disable the `cl_intel_subgroups` extension (which is the extension that brings in `sub_group_barrier` with CL1.2 for the generic `spir` triple).  Adding a new `RUN` line or new test file for just this case seems a bit of an overkill, so I'm tempted to defer this until we have parity between `OpenCLBuiltins.td` and `opencl-c.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120254/new/

https://reviews.llvm.org/D120254



More information about the cfe-commits mailing list