[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 31 02:47:22 PDT 2022


martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

Thanks! Good catch!

(For inexperienced readers, let me explain why I accepted the patch: If there is an error then the imported Decl is marked as erroneous, i.e an Error object is associated with the imported Decl, thus users of the ASTImporter can react according to the set error.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122528/new/

https://reviews.llvm.org/D122528



More information about the cfe-commits mailing list