[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

Wed Mar 30 13:04:40 PDT 2022

aaron.ballman added inline comments.

================
Comment at: clang/lib/Parse/ParseDecl.cpp:6965-6966
     // Parse GNU attributes, if present.
     MaybeParseGNUAttributes(ParmDeclarator);
+    MaybeParseHLSLSemantics(DS.getAttributes());

----------------
beanz wrote:
> aaron.ballman wrote:
> > This means the order is very specific -- should this be using `MaybeParseAttributes()` so that the syntaxes can be intermingled?
> > 
> > This reminds me, I don't see a change to `ParseAttrKindMask`, but perhaps we want that for both the microsoft and HLSL semantic attributes?
> This is kinda 6 one way half dozen the other. GNU attribute syntax isn't supported in HLSL, I just haven't gotten around to disabling it yet.
> 
> If you have a preferred implementation I'm happy to go whatever way you suggest.
> 
> The HLSL language doesn't support Semantics or Microsoft-style attributes in all that many places in code. MS attributes are only used on functions, and semantics are restricted to input/output data (which is a little more complicated than it sounds, but basically is function parameters, returns, global variables and struct members).
Okay, then let's leave this as-is -- we can address it if someone hits an actual pain point.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122699/new/

https://reviews.llvm.org/D122699