[PATCH] D122748: [Sema] Don't check bounds for function pointer

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I think I'm generally in favor, would still like to see the feedback from the original submitter here to see if there is more work to do in here that would be valuable.



================
Comment at: clang/lib/Sema/SemaChecking.cpp:15471
   if (IsUnboundedArray) {
+    if (EffectiveType->isFunctionType())
+      return;
----------------
Ah, I see...  I originally made the comment thinking that we wanted to be able to get to ~15540 (which this 'return' would seem to undo), but I see this block ends in 'return' anyway.  I'm happy with this change the way it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122748/new/

https://reviews.llvm.org/D122748