[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 12:18:33 PDT 2022


beanz added a comment.

@aaron.ballman I pushed updates in rGff6696c842ba <https://reviews.llvm.org/rGff6696c842bac0b15fc04015b25ead721768eac9>.

The one bit we discussed that I didn't do anything for is the template case. Neither clang or the HLSL compiler support parsing Microsoft attributes on templates right now, so the parser falls over and errors. It would be better to have a nicer diagnostic, but since the current state matches our compiler I left it as-is.

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122627/new/

https://reviews.llvm.org/D122627



More information about the cfe-commits mailing list