[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

Wed Mar 30 06:27:02 PDT 2022

quinnp marked an inline comment as done.
quinnp added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208
-  for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) {
-    if (E->getArg(i)->getType()->isArrayType())
-      Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());
----------------
quinnp wrote:
> amyk wrote:
> > A question I have is do we not need to consider this/`EmitArrayToPointerDecay()` anymore? Was this not used for anything?
> Thanks for your comment! I could not find any builtins that used this case in the loop for emitting their arguments and did not see any failures when I removed it. I am going to look into this now and verify whether or not this is needed.
I've updated the patch to include `EmitArrayToPointerDecay()` where it is needed and add code generation testcases to test this functionality.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121637/new/

https://reviews.llvm.org/D121637